You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Seems it's the same functionality as #13, but more polished here. I like the AllowNull attribute to explicitely enable the nil non-standard feature.
Python implementation has this approach as well, and I like that this non-standard feature is not enabled by default too.
This is different from #13 as #13 is about deserializing response data which have NULL values. This (#11) allows to send NULL values as parameters of method in the XML-RPC request.
However, I thing #13 could be more polished if deserialization would take XmlRpcMissingMapping(MappingAction.Ignore) attribute into account for data deserialization. For example:
public class MyResult
{
public string propertyOne;
[XmlRpcMissingMapping(MappingAction.Ignore)] // don't care if server don't return this field
public string propertyTwo;
}
Solution could allow NULL (<nil/>) for propertyTwo but does not allow NULL for propertyOne and rise exception as in standard behavior. Of course, if I understand the project correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add NonStandard option
AllowNullto allow serialization of method calls with NULL values in parameters.It is well supported XML-RPC extension: https://web.archive.org/web/20130120074804/http://ontosys.com/xml-rpc/extensions.php